Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUD-1114] Add slot diff in discovery responses #2099

Merged
merged 2 commits into from
Nov 24, 2021

Conversation

raymondjacobson
Copy link
Member

@raymondjacobson raymondjacobson commented Nov 24, 2021

Description

Add plays slot info to all API responses so they can be monitored on every request and allow clients to reselect.

Tests

Local stack, verify API responses

How will this change be monitored?

Should be a no-op until clients decide to consume values

@raymondjacobson raymondjacobson changed the title Add slot diff in discovery responses [AUD-1114] Add slot diff in discovery responses Nov 24, 2021
Copy link
Contributor

@hareeshnagaraj hareeshnagaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but how would we handle legacy plays?

"time_diff_general": time_diff_general
this does have a fallback to time_diff_general which includes the legacy difference. might not be a real issue though since sol has been generally up

@raymondjacobson
Copy link
Member Author

This looks fine, but how would we handle legacy plays?

"time_diff_general": time_diff_general

this does have a fallback to time_diff_general which includes the legacy difference. might not be a real issue though since sol has been generally up

we went for a long time w/o this sort of health check on the legacy fallback. i think it's ok for the purposes of this b/c we aren't seeing a huge discrepancy in that system between nodes. this would be to near-term prevent us from picking a behind sol indexing discovery node

@raymondjacobson raymondjacobson merged commit 1b1c834 into master Nov 24, 2021
@raymondjacobson raymondjacobson deleted the rj-slot-diff-in-responses branch November 24, 2021 23:18
@AudiusProject AudiusProject deleted a comment from linear bot Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants