Set production rewards config #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piazzatron
force-pushed
the
dn-rewards-canary
branch
from
41d6d53
to
8815c15
Compare
piazzatron
force-pushed
the
dn-rewards-canary
branch
from
8815c15
to
52bc3bf
Compare
piazzatron
force-pushed
the
dn-rewards-canary
branch
from
52bc3bf
to
8af71f7
Compare
piazzatron
added
the
discovery-node
raymondjacobson
approved these changes
Jan 12, 2022
There was a problem hiding this comment.
Note that this change was to prevent empty strings in the env (audius-k8s) from overriding values
it looks like encoding the solana rewards config in default_config.ini doesn’t work bc some of these fields are set to to empty strings in k8s, which apparently overrides the default_config
i'll add a comment just for clarity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rewards config for prod
Tests
Tested with live ammo on prod
How will this change be monitored?