Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename trending challenges #2316

Merged
merged 10 commits into from
Jan 15, 2022
Merged

Rename trending challenges #2316

merged 10 commits into from
Jan 15, 2022

Conversation

piazzatron
Copy link
Contributor

@piazzatron piazzatron commented Jan 14, 2022

Description

  • Changes challenge names so our transferId < 32 chars always
  • Fix date specifier precision
  • Fix double ':' parsing error

Tests

Tested on stage

How will this change be monitored?

@piazzatron piazzatron force-pushed the piazz-trending-rename branch 2 times, most recently from 4d461e5 to e424e72 Compare January 14, 2022 22:29
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 14, 2022
@pull-request-size pull-request-size bot added size/M and removed size/L labels Jan 14, 2022
@piazzatron piazzatron changed the title [NO MERGE] Rename trending challenges Rename trending challenges Jan 14, 2022
Copy link
Contributor

@jowlee jowlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@piazzatron piazzatron merged commit 26186a0 into master Jan 15, 2022
@piazzatron piazzatron deleted the piazz-trending-rename branch January 15, 2022 00:17
raymondjacobson pushed a commit that referenced this pull request Jan 15, 2022
* Rename trending challenges

* Drop challenge migration

* Fix lint

* Remove extra fmt

* Fix test

* Fix migration

* Fix datetime conversion

* Handle double colon

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants