Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise MissingRequired error when no handle is found for a track #2323

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

raymondjacobson
Copy link
Member

@raymondjacobson raymondjacobson commented Jan 18, 2022

Description

Adds a MissingRequired exception when the user for a track is not found as a part of the indexing flow. The handle is necessary to retrieve to create the track permalink (handle/track-name) and if we somehow failed to index that user, we need to skip ahead of this tx.

Tests

Deployed on prod discovery 2 and fixed stall

How will this change be monitored?

Copy link
Contributor

@dmanjunath dmanjunath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent

Copy link
Contributor

@csjiang csjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this is an elegant fix.

Copy link
Contributor

@hareeshnagaraj hareeshnagaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raymondjacobson raymondjacobson merged commit d024057 into master Jan 18, 2022
@raymondjacobson raymondjacobson deleted the rj-halt-fix branch January 18, 2022 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants