Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUD-1348] Add verified referral challenge #2367

Merged
merged 3 commits into from
Jan 22, 2022

Conversation

piazzatron
Copy link
Contributor

Description

  • Adds a new challenge, referrals-verified
  • Add logic to filter out challenges from get_challenges for a particular user, and applies this to the two referral challenge types

Tests

  • Added tests. Need to test on staging staging

How will this change be monitored?

Copy link
Member

@raymondjacobson raymondjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no issues!!

)
.all()
)
assert len(challenges) == 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

# - No regular referrals are made

for i in range(510):
dispatch_new_user_signup(verified_user.user_id, 14 + i, session, bus)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-op needed, but the 14 + i is pretty brittle

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed

if (
challenge.active
and not challenge.type == ChallengeType.trending
and event_bus.get_manager(challenge.id).should_show_challenge_for_user(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@piazzatron piazzatron changed the title Add verified referral challenge [AUD-1348] Add verified referral challenge Jan 22, 2022
@piazzatron piazzatron merged commit 0a5f4e0 into master Jan 22, 2022
@piazzatron piazzatron deleted the discovery-verified-referral branch January 22, 2022 02:54
@AudiusProject AudiusProject deleted a comment from linear bot Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants