Fix unlisted tracks in track upload challenge #2382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondjacobson
approved these changes
Jan 25, 2022
| @@ -135,6 +150,17 @@ def test_track_upload_challenge(app): | |||
| assert user_challenge.current_step_count == 1 | |||
| assert not user_challenge.is_complete | |||
|
|
|||
| # Ensure unlisted track is not counted | |||
| session.add(unlisted_track) | |||
| bus.dispatch(ChallengeEvent.track_upload, 30000000, 1) | |||
There was a problem hiding this comment.
should this be 30000001?
There was a problem hiding this comment.
shouldn't affect the test but for consistency yep, will change
| @@ -58,6 +58,7 @@ def _get_num_track_uploads_by_user( | |||
| Track.blocknumber >= block_number, | |||
| Track.is_current == True, | |||
| Track.is_delete == False, | |||
| Track.is_unlisted == False | |||
There was a problem hiding this comment.
should we do a stem check too?
piazzatron
added a commit
that referenced
this pull request
Jan 25, 2022
* Fix unlisted tracks in track upload challenge * PR revisions * Fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stop counting unlisted tracks towards track upload completion.
Tests
How will this change be monitored?