[ASI-836] [CN] Add reconfigNodewhitelist envvar & consume in reconfig #2447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SidSethi
changed the title
dmanjunath
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
reconfigNoteWhitelistconfig var to content node, defaulted to noneThis config var piggy back's off libs
CreatorNodeSelectionlogic, which already exposed awhitelistparamConsumes var in snapback stateMachineQueue to allow whitelisting of reconfig node selection
Also adds unit test of CreatorNodeSelection whitelist flag
Tests
libs CreatorNodeSelection unit test coverage of whitelist param
Mad-dog base run confirms stateMachineQueue logic works when whitelist is not provided
Manually confirmed that whitelist works when values provided
Note - for now, i enabled logging for the CreatorNodeSelection (in CN only), i think it's reasonable to leave this on for a bit and disable later
How will this change be monitored? Are there sufficient logs?
Look for
CreatorNodeSelection - final decision tree statelogs in CN to ensure whitelist logic is working correctly