Upgrade solana.py to 0.21.0, web3.py to 6.0.0b1 #2751
Conversation
jowlee
force-pushed
the
ASI-971_upgrade_solanapy
branch
from
cc90e30
to
a243204
Compare
There was a problem hiding this comment.
Can we try and absorb getTransaction here? instead of getConfirmedTransaction - https://michaelhly.github.io/solana-py/rpc/api/#solana.rpc.api.Client.get_transaction
https://docs.solana.com/developing/clients/jsonrpc-api#getconfirmedtransaction <-- being deprecated
| @@ -714,7 +749,7 @@ workflows: | |||
|
|
|||
| - test-discovery-provider: | |||
| name: test-discovery-provider | |||
| - docker-build-and-push: | |||
| - docker-build-and-push-updated: | |||
There was a problem hiding this comment.
can we leave it build-and-push bc we're replacing the old one?
There was a problem hiding this comment.
The updated one uses a new base image - I didn't want to go through the process of updating the build for all the services Base image circleci/buildpack-deps:stretch => cimg/base:2022.03
jowlee
force-pushed
the
ASI-971_upgrade_solanapy
branch
2 times, most recently
from
1ccf953
to
39202d7
Compare
jowlee
force-pushed
the
ASI-971_upgrade_solanapy
branch
from
39202d7
to
7ce1e9c
Compare
| @@ -9,8 +9,7 @@ types-redis==3.5.4 | |||
| types-requests==2.25.0 | |||
| types-pytz==2021.1.2 | |||
|
|
|||
| # web3 used to be 5.11.0 but due to a build issue in docker, downgraded to 5.8.0 | |||
| web3==5.8.0 | |||
| web3==6.0.0b1 | |||
There was a problem hiding this comment.
can we add some details as to why we are on 6.0.0.b1?
There was a problem hiding this comment.
it is the only version that supports websockets v10.1 and that's the version of ws we need for solana-py version that is compatible w anchor py
This will be addressed in a follow up |
Description
Upgrade solana.py version to a version compatible with anchor.py for tx parsing. Solana.py requires websockets >10.1 so we're also upgrading web3.py to a version compatible with websockets >10.1.
Tests
Fixing integration tests
How will this change be monitored? Are there sufficient logs?
N/A