[ASI-860] Enforce max wallet size in content-node batch_clock_status

[theoilie]

Description

• Enforces Snapback’s MAX_BATCH_CLOCK_STATUS_BATCH_SIZE directly in content-node’s /users/batch_clock_status route

Tests

• Added test to verify error 400 when batch size is exceeded

How will this change be monitored? Are there sufficient logs?

I'm not aware of any health checks for this endpoint. Consumers of the route would rely on the error message covered in a test: Number of wallets must not exceed ${maxNumWallets} (reduce 'walletPublicKeys' field in request body).

[SidSethi]

this looks great - nice work!!

one thing i just thought of - it would be nice to set a lower value for local dev to ensure that the batching is properly tested each time, maybe 3 or 4

let me or @dmanjunath know if want to talk through how to do that

also nice to see you added the test!

ps - there's a Monitoring / logging section in the PR description template we should not remove. mind filling that in?

[dmanjunath]

@SidSethi not sure if we should diverge the batch size between local and other envs. might be easiest to override the value locally if you want to change it?

[SidSethi]

@SidSethi not sure if we should diverge the batch size between local and other envs. might be easiest to override the value locally if you want to change it?

i dont feel strongly about this but it seems like it would be pretty valuable to have the batching flow tested each time
can we not set the default to 5000 in config.js and set the local value in compose/env/base.env or compose/env/common.env?

[dmanjunath]

not really sure what having a lower threshold in dev does but i'll trust your call. we can move this to an env var and set non-dev default to 5000 and set a development env var override to 5

[theoilie]

thanks for the feedback! I addressed all the comments, so please let me know if there are any other changes you want me to make @SidSethi

[SidSethi]

not really sure what having a lower threshold in dev does but i'll trust your call. we can move this to an env var and set non-dev default to 5000 and set a development env var override to 5

yeah the main benefit would be to have each maddog run actually test this but since maddog base run only creates 2 users we would not get any benefit except for in manual testing at which point we could just manually override as needed

[SidSethi]

looks great! one thing to change

[SidSethi]

looks great!

couple things

1. lets update the Monitoring/logging section to specify the exact error msg
2. lets make sure that the base maddog test passes locally still (it usually errors in CI, idk why)

[theoilie]

looks great!

couple things

1. lets update the Monitoring/logging section to specify the exact error msg
2. lets make sure that the base maddog test passes locally still (it usually errors in CI, idk why)

updated the README and restarted mad dog in Circle (it passed in the 2nd-most-recent merge from master)