Fix discprov image dirCID indexing #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hareeshnagaraj
approved these changes
Feb 4, 2020
There was a problem hiding this comment.
looks good to me, i would prefer if we could somehow emulate the single byte cat (maybe with request streaming up to a limited size or something - which is possible in python) but let's get this in, we will have to revisit our dir behavior eventually anyway.
let's confirm this works by running locally against stage before checking in?
dmanjunath
suggested changes
Feb 4, 2020
SidSethi
force-pushed
the
ss-discprov-dircid-indexing-bugfix
branch
from
9ec8d37
to
f0b555f
Compare
SidSethi
force-pushed
the
ss-discprov-dircid-indexing-bugfix
branch
from
f0b555f
to
ee7af53
Compare
dmanjunath
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes discprov image indexing when local cat fails. Regression occurred after we added multi-res images and changed the cnode ipfs gateway route API. The indexing code was still pinging the non-dir image gateway route on cnode, which no longer returns error msg indicating CID is a directory. Logic now first checks the dir image gateway route.
Tested fallback logic by removing the local cat logic at beginning of function so it has to ping the gateways.
Tested non-dir image fallback logic by running local discprov against staging chain from scratch.