Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get_transaction to be base64 #2809

Merged
merged 2 commits into from
Apr 1, 2022
Merged

Conversation

jowlee
Copy link
Contributor

@jowlee jowlee commented Apr 1, 2022

Description

Updated the tx_parser script to use solana get_transaction to use base64 encoding to lighten load on RPC node

Tests

Checked that the tx_parser script could still parse out the tx

How will this change be monitored? Are there sufficient logs?

To be integrated in the parser

Copy link
Contributor

@csjiang csjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice!

Copy link
Contributor

@hareeshnagaraj hareeshnagaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@jowlee jowlee merged commit 860c20f into master Apr 1, 2022
@jowlee jowlee deleted the jowlee-get-transaction-base64 branch April 1, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants