Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUD-1828] Remove routes from external documentation #2856

Merged
merged 7 commits into from
Apr 7, 2022

Conversation

rickyrombo
Copy link
Contributor

Description

These routes are not useful for third parties and add confusion. Removing them to make the API docs clearer.

Also updates the flask plugin to account for a new edge case.

Tests

Verified that swagger output looks as expected.

How will this change be monitored? Are there sufficient logs?

@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 6, 2022
Copy link
Member

@raymondjacobson raymondjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fix the schemas too?

@gitguardian
Copy link

gitguardian bot commented Apr 7, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
3086103 Generic High Entropy Secret b1e39a2 discovery-provider/integration_tests/tasks/test_anchor_program_indexer.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@rickyrombo rickyrombo merged commit a5ea573 into master Apr 7, 2022
@rickyrombo rickyrombo deleted the mjp-remove-route-docs branch April 7, 2022 18:15
@AudiusProject AudiusProject deleted a comment from linear bot Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants