unit tests for creator-node/src/routes/track.js #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SidSethi
reviewed
Feb 7, 2020
creator-node/test/tracks.js
Outdated
| .expect(400) | ||
| }) | ||
|
|
||
| it.only('downloads downloadable track with no track_id', async function () { |
There was a problem hiding this comment.
not a "download", just a metadata submission
vicky-g
changed the title
vicky-g
changed the title
SidSethi
reviewed
Feb 10, 2020
creator-node/package.json
Outdated
| @@ -5,6 +5,8 @@ | |||
| "scripts": { | |||
| "start": "nodemon src/index.js | ./node_modules/.bin/bunyan || exit 0", | |||
| "test": "./scripts/run-tests.sh", | |||
| "coverage": "nyc npm run test", | |||
| "report": "nyc report --reporter=html", | |||
There was a problem hiding this comment.
would be good to add a comment somewhere about what purpose these commands serve
creator-node/.gitignore
Outdated
| test_file_storage/ | ||
| coverage/ |
There was a problem hiding this comment.
looks like nyc generates a .nyc_output/ dir as well, lets add that here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 2 unit tests to
creator_node/test/track.js:track_idandsource_idis not present, service should throw and errordownload.is_downloadable: true, download.cid: <cid>into metadata obj., a downloadable track should be created and return 200