Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update anchor parser to map account names and pubkeys #2866

Merged
merged 7 commits into from
Apr 7, 2022

Conversation

isaacsolo
Copy link
Contributor

@isaacsolo isaacsolo commented Apr 6, 2022

Description

Update anchor parser to map account names to their pubkeys and restructure anchor_parser to be a class that has an InstructionCoder. This will help with getting account pubkeys in indexing.

Fixes ASI-1025.

Tests

Tested manually and verified in mapping in logs.

{'instructions': [{'instruction_name': 'init_admin', 'accounts': (OrderedDict([('admin', 'FgJunUE6VhQ3XqaktoM3jt9JQb2fuQcR18NFi68Zn4JG'), ('payer', '6PFePteV78tkfnbTQ9TkNboXG8pWXTVHRsHLp2446uJv'), ('systemProgram', '11111111111111111111111111111111')]), ['FgJunUE6VhQ3XqaktoM3jt9JQb2fuQcR18NFi68Zn4JG', '6PFePteV78tkfnbTQ9TkNboXG8pWXTVHRsHLp2446uJv', '11111111111111111111111111111111']), 

How will this change be monitored? Are there sufficient logs?

No monitoring.

@isaacsolo isaacsolo changed the title Update anchor parser to map account names and keys Update anchor parser to map account names and pubkeys Apr 7, 2022
@isaacsolo isaacsolo marked this pull request as ready for review April 7, 2022 00:30
@isaacsolo isaacsolo requested review from hareeshnagaraj and csjiang and removed request for hareeshnagaraj April 7, 2022 00:30
Copy link
Contributor

@csjiang csjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for doing this work. Looks really good!

Copy link
Contributor

@hareeshnagaraj hareeshnagaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gitguardian
Copy link

gitguardian bot commented Apr 7, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
3086103 Generic High Entropy Secret 392ea76 discovery-provider/integration_tests/tasks/test_anchor_program_indexer.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@isaacsolo isaacsolo merged commit 92b7fe1 into master Apr 7, 2022
@isaacsolo isaacsolo deleted the is-parse-accounts branch April 7, 2022 16:05
@AudiusProject AudiusProject deleted a comment from linear bot Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants