filtering out any deleted tracks in dp endpoints #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicky-g
changed the title
vicky-g
changed the title
vicky-g
requested review from
jowlee,
raymondjacobson,
hareeshnagaraj and
SidSethi
SidSethi
reviewed
Feb 25, 2020
SidSethi
reviewed
Feb 25, 2020
raymondjacobson
approved these changes
Feb 26, 2020
SidSethi
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the original task was to filter out all deleted tracks in dp endpts, but upon further discussion, that shouldn't be the case.
Tombstones should show up for deleted tracks on/in:
Tracks that are deleted should not be shown in/on:
With this in mind, the queries have been modified to filter out deleted tracks in only the relevant methods.