Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discovery provider lock update + updated logs #306

Merged
merged 4 commits into from
Mar 10, 2020
Merged

Discovery provider lock update + updated logs #306

merged 4 commits into from
Mar 10, 2020

Conversation

hareeshnagaraj
Copy link
Contributor

No description provided.

@hareeshnagaraj
Copy link
Contributor Author

discprov 3 failures TAKEAWAYS

@SidSethi SidSethi changed the title [WIP] Discovery provider lock update + updated logs [HOLD][WIP] Discovery provider lock update + updated logs Mar 2, 2020
dmanjunath
dmanjunath reviewed Mar 2, 2020
View reviewed changes
Copy link
Contributor

@dmanjunath dmanjunath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we clear this lock when the indexing task starts?

@hareeshnagaraj hareeshnagaraj changed the title [HOLD][WIP] Discovery provider lock update + updated logs Discovery provider lock update + updated logs Mar 10, 2020
@hareeshnagaraj hareeshnagaraj merged commit 4632feb into master Mar 10, 2020
@hareeshnagaraj hareeshnagaraj deleted the hn_index_update_redis_lock_fix branch March 10, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanjunath dmanjunath dmanjunath approved these changes

@SidSethi SidSethi Awaiting requested review from SidSethi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hareeshnagaraj @dmanjunath