Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check route_id only for unlisted tracks #307

Merged
merged 3 commits into from
Mar 3, 2020
Merged

check route_id only for unlisted tracks #307

merged 3 commits into from
Mar 3, 2020

Conversation

vicky-g
Copy link
Contributor

@vicky-g vicky-g commented Mar 2, 2020 •
edited

@vicky-g vicky-g changed the title check for route_id only for unlisted tracks check route_id only for unlisted tracks Mar 2, 2020
piazzatron
piazzatron reviewed Mar 2, 2020
View reviewed changes
Copy link
Contributor

@piazzatron piazzatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're fast! And it looks nice and pythonic.

discovery-provider/src/queries/queries.py Outdated Show resolved Hide resolved
discovery-provider/src/queries/queries.py Outdated Show resolved Hide resolved
discovery-provider/src/queries/queries.py Outdated Show resolved Hide resolved
discovery-provider/src/queries/queries.py Outdated Show resolved Hide resolved
SidSethi
SidSethi reviewed Mar 2, 2020
View reviewed changes
discovery-provider/src/queries/queries.py Outdated Show resolved Hide resolved
discovery-provider/src/queries/queries.py Outdated Show resolved Hide resolved
piazzatron
piazzatron approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@piazzatron piazzatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

SidSethi
SidSethi approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@SidSethi SidSethi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@vicky-g vicky-g merged commit c3bf2cc into master Mar 3, 2020
@vicky-g vicky-g deleted the vg-backlinks branch March 3, 2020 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SidSethi SidSethi SidSethi approved these changes

@piazzatron piazzatron piazzatron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vicky-g @SidSethi @piazzatron