Add trending/underground non-full endpoint #3944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michellebrier
commented
Sep 27, 2022
| }, | ||
| ) | ||
| @ns.route( | ||
| "/trending/underground/<string:version>", |
There was a problem hiding this comment.
do we also want this non-full route for /trending/underground/<string:version>?
There was a problem hiding this comment.
probably ok not too. the story of why we have this is when we update the trending algo, we want to make sure that while services waterfall updates the client sees a consistent view of trending
There was a problem hiding this comment.
you already did it though, so no need to undo!
michellebrier
requested review from
a team and
raymondjacobson
and removed request for
a team
raymondjacobson
approved these changes
Sep 28, 2022
| }, | ||
| ) | ||
| @ns.route( | ||
| "/trending/underground/<string:version>", |
There was a problem hiding this comment.
you already did it though, so no need to undo!
rickyrombo
approved these changes
Sep 28, 2022
audius-infra
pushed a commit
that referenced
this pull request
Sep 30, 2022
## Changelog - 2022-09-29 [13bd5ff] Gating entity manager replica set updates with identity service (#3965) [Isaac Solo] - 2022-09-28 [b7230e2] Add a getter for userBankTransactionMetadata (#3962) [Marcus Pasell] - 2022-09-28 [d99a1f8] Add trending/underground non-full endpoint (#3944) [Michelle Brier] - 2022-09-28 [f88869d] Bump sdk to v1.0.7 [audius-infra]
audius-infra
pushed a commit
that referenced
this pull request
Sep 30, 2022
## Changelog - 2022-09-29 [13bd5ff] Gating entity manager replica set updates with identity service (#3965) [Isaac Solo] - 2022-09-28 [b7230e2] Add a getter for userBankTransactionMetadata (#3962) [Marcus Pasell] - 2022-09-28 [d99a1f8] Add trending/underground non-full endpoint (#3944) [Michelle Brier] - 2022-09-28 [f88869d] Bump sdk to v1.0.7 [audius-infra]
vicky-g
pushed a commit
that referenced
this pull request
Oct 4, 2022
* Add trending/underground non-full API endpoint * Generate libs types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add non-full API endpoint for
tracks/trending/undergroundTests
Make sure existing tests pass. Deploy and test endpoint on stage
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?