Add Discovery Sitemap Endpoint #3973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sliptype
approved these changes
Sep 30, 2022
| return "https://audius.co" | ||
|
|
||
|
|
||
| def set_set_base_url(): |
There was a problem hiding this comment.
Is this name right? set_set 🤔
jowlee
added a commit
that referenced
this pull request
Oct 4, 2022
* Add sitemap methods to discovery * Fix sitemap urls and add tests * rename route for sitemap to be more consistent * Fix double set * Fix integration test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds sitemap endpoints to the discovery node to generate the xml files for user/track/playlist routes
Adds endpoints:
/sitemap/base.xmlreturns the base sitemap for the static routes/sitemap/<string:type>/base.xmlReturns a list of links to other sitemaps for that type/sitemap/<string:type>/<string:file_name>Returns a list of the urls to indexTests
Wrote some tests with mock data and ran the discovery node against a staging DB to verify the correct links
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?
Can use the google webmaster tool to check
Fixes: PLAT-343
Fixes: PLAT-322