Discovery indexing user verification #4035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacsolo
reviewed
Oct 5, 2022
| @@ -133,3 +149,31 @@ def update_user(params: ManageEntityParameters): | |||
| params.add_user_record(user_id, user_record) | |||
|
|
|||
| return user_record | |||
|
|
|||
|
|
|||
| def verify_user(params: ManageEntityParameters): | |||
There was a problem hiding this comment.
does the user signup flow cover send a verify user tx? i guess all create_user txs have is_verified false to start
There was a problem hiding this comment.
Well the user signup flow covers associating instagram or twitter - which is done with identity service.
When that happens, we check in identity if the user is verified and identity sends the request
isaacsolo
reviewed
Oct 5, 2022
isaacsolo
reviewed
Oct 5, 2022
isaacsolo
reviewed
Oct 5, 2022
isaacsolo
approved these changes
Oct 5, 2022
jowlee
added a commit
that referenced
this pull request
Oct 10, 2022
* Add veirfy user action * lint * Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add User verified action via entity manager
Tests
Wrote a test to validate that a valid tx updates the user verified and an invalid tx does not update the user model
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?