Convert AsyncProcessingQueue to typescript
#4098
Conversation
jonaylor89
changed the title
AsyncProcessingQueue to typescript
…/audius-protocol into jn-type-asyncqueue merge
| }) | ||
| } else { | ||
| // eslint-disable-next-line @typescript-eslint/no-floating-promises |
There was a problem hiding this comment.
can we just have 1 global lint for this floating promise?
There was a problem hiding this comment.
if so, let's remove the one liners and add it to the global top of the file
There was a problem hiding this comment.
We can ad a file-wide lint. I'll make a note to add it in the follow up PR with the CustomRequest type
|
|
||
| const ASYNC_PROCESSING_QUEUE_HISTORY = 500 | ||
| type AddTaskParams = { | ||
| logContext: { requestID: string } |
There was a problem hiding this comment.
i think we should make this type any because even though we're only printing the requestID here, there may be other fields that are passed in.
There was a problem hiding this comment.
also like how here logContext is of type any https://github.com/AudiusProject/audius-protocol/pull/4098/files#diff-330e68b54fe69419f61d4adb76b7b255968de4a8b28166059adc53b03fae1136R277
There was a problem hiding this comment.
I wanna avoid making it any if possible. Perhaps we can add a LogContext type in utils somewhere so both CustomRequest and AddTaskParams can use it
There was a problem hiding this comment.
is there a reason you are against using the type any? i would support making LogContext a type but i think there are too many different additional variables besides the base fields (requestID, requestMethod, etc. see getRequestLoggingContext())
Description
This PR converts AsyncProcessingQueue to typescript and changes how its exported to align with the other typescript files
Tests
I'm using the original tests to make sure nothing broke
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?
This will be monitored with the typechecker