CN performance stabilization tweaks #4145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanjunath
approved these changes
Oct 17, 2022
creator-node/src/services/stateMachineManager/stateReconciliation/index.js
Show resolved
Hide resolved
| @@ -48,7 +48,7 @@ class ClusterUtils { | |||
|
|
|||
| // This is called `cpus()` but it actually returns the # of logical cores, which is possibly higher than # of physical cores if there's hyperthreading | |||
| const logicalCores = cpus().length | |||
| return config.get('expressAppConcurrency') || logicalCores | |||
| return (config.get('expressAppConcurrency') || logicalCores) / 2 | |||
There was a problem hiding this comment.
i was thinking this but w/e
Suggested change
| return (config.get('expressAppConcurrency') || logicalCores) / 2 | |
| return config.get('expressAppConcurrency') || (logicalCores / 2) |
There was a problem hiding this comment.
oh yeah, good point
theoilie
approved these changes
Oct 17, 2022
| @@ -48,7 +48,7 @@ class ClusterUtils { | |||
|
|
|||
| // This is called `cpus()` but it actually returns the # of logical cores, which is possibly higher than # of physical cores if there's hyperthreading | |||
| const logicalCores = cpus().length | |||
| return config.get('expressAppConcurrency') || logicalCores | |||
| return (config.get('expressAppConcurrency') || logicalCores) / 2 | |||
There was a problem hiding this comment.
wondering if this should Math.ceil for machines with 1 core so it's not 0.5 which truncates to 0? approving for either way since none of our local, staging, or prod nodes need to worry about that scenario
dmanjunath
approved these changes
Oct 17, 2022
SidSethi
added a commit
that referenced
this pull request
Oct 17, 2022
SidSethi
added a commit
that referenced
this pull request
Oct 17, 2022
SidSethi
added a commit
that referenced
this pull request
Oct 17, 2022
dmanjunath
pushed a commit
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
maxWaitingJobsforrecurringSyncQueueandupdateReplicaSetQueueby 10xrecurringSyncQueueandupdateReplicaSetQueuebased on envvarsTests
automated sufficient
also tested manually on staging node
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?
Easy to monitor all above via bull dashboard, grafana bull dashboard, and grafana profiling dashboard