Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up unused libs param #4163

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Clean up unused libs param #4163

merged 1 commit into from
Oct 25, 2022

Conversation

theoilie
Copy link
Contributor

Description

Cleans up references to a libs param that is no longer used - no need to pass it in anymore from other consumers and tests.

Tests

CI passing is sufficient.

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

N/A

@theoilie theoilie added the content-node Content Node (previously known as Creator Node) label Oct 25, 2022
jonaylor89
jonaylor89 approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@jonaylor89 jonaylor89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate it - LGTM

@theoilie theoilie merged commit 59b086a into master Oct 25, 2022
@theoilie theoilie deleted the theo-clean-up-unused-libs branch October 25, 2022 00:59
dmanjunath pushed a commit that referenced this pull request Oct 31, 2022
@theoilie @dmanjunath
Clean up unused libs param (#4163)
301b26e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaylor89 jonaylor89 jonaylor89 approved these changes

@dmanjunath dmanjunath Awaiting requested review from dmanjunath

Assignees
No one assigned
Labels
content-node Content Node (previously known as Creator Node) size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@theoilie @jonaylor89