Remove performSimpleCheck flag #4168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dm-remove-simple-check-flag
theoilie
approved these changes
Oct 25, 2022
SidSethi
approved these changes
Oct 25, 2022
dmanjunath
added a commit
that referenced
this pull request
Oct 31, 2022
* Remove performSimpleCheck flag * Test fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the distinction between simple and full peer health checks in CNodeHealthManager. All health check requests will check health, storage and file descriptors.
This was necessary to reconfig off primaries that ran out of storage. Without this, we never checked storage available on primaries.
Tests
This flow has good test coverage so made sure unit tests all pass.
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?
In bull dashboard unhealthPeers correctly returns unhealthy nodes