Convert diskManager to typescript
#4195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theoilie
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
it's hard to see the actual changes since GitHub doesn't put it side-by-side after renaming JS->TS but it looks good from what I can tell. after resolving merge conflicts I'd want to do an extra test on staging for orphaned data recovery and Dheeraj's disk sweep since those won't necessarily bubble up any obvious errors
dmanjunath
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR converts
diskManager.jsto typescript. It also removes the diskManager class since it was all static members in favor of just a collection of exported functionsTests
Just using integration tests and maddog to make sure nothing breaks
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?
This change will be monitored with the type checker