Remove redis primarySyncFromSecondary fail-safes #4213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanjunath
approved these changes
Oct 28, 2022
dmanjunath
pushed a commit
that referenced
this pull request
Oct 28, 2022
dmanjunath
pushed a commit
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes redis set fail-safes that were causing secondary->primary syncs to fail for users who have rows that are identical in every column except clock value.
Tests
Ran
curl -X POST "http://cn1_creator-node_1:4000/merge_primary_and_secondary?wallet=0x7d273271690538cf855e5b3002a0dd8c154bb060&endpoint=https://audius-content-3.cultur3stake.com&syncEvenIfDisabled=true&forceWipe=true"to sync from a prod secondary to my local CN1 as primary before and after these changes using a debugger to check each step. I also manually inspected the duplicates to ensure this change doesn't lead to any corrupted state.Monitoring - How will this change be monitored? Are there sufficient logs / alerts?
We shouldn't see the following error anymore:
Error - Failed to save entries to DB: Failed to add all entries to redis set for FILTER_OUT_ALREADY_PRESENT_DB_ENTRIES_FETCHED_ENTRIES_SET.