Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix health check with web3 poa middleware #4229

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Fix health check with web3 poa middleware #4229

merged 1 commit into from
Oct 31, 2022

Conversation

isaacsolo
Copy link
Contributor

@isaacsolo isaacsolo commented Oct 31, 2022 •
edited

Description

Health check caching would fail without this middleware during get_health but caching during indexing does have this middleware and would succeed.

Tests

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

@isaacsolo isaacsolo marked this pull request as ready for review October 31, 2022 16:03
stereosteve
stereosteve approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@stereosteve stereosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@isaacsolo isaacsolo merged commit 5d3bf95 into main Oct 31, 2022
@isaacsolo isaacsolo deleted the is-fix-poa-health-check branch October 31, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stereosteve stereosteve stereosteve approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@isaacsolo @stereosteve