-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert ffmpeg
to typescript
#4256
Conversation
can tag me whenever RFR |
see if main merge fixes CI |
…ius-protocol into jn-type-ffmpeg merge
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
3939057 | Generic High Entropy Secret | fe073d2 | service-commands/src/utils/constants.js | View secret |
4714545 | Generic High Entropy Secret | fe073d2 | service-commands/src/utils/constants.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try merging main again? maddog failing on last commit still :/
i think prob good to merge, but def gotta make sure everything ok on staging
Description
Converts
ffmpeg
module to typscriptTests
Just using original tests to make sure nothing broke
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?
This change will be monitored with the typechecker