Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CN tests #4267

Merged
merged 6 commits into from
Nov 4, 2022
Merged

Fix CN tests #4267

merged 6 commits into from
Nov 4, 2022

Conversation

SidSethi
Copy link
Contributor

@SidSethi SidSethi commented Nov 2, 2022

Description

removeTrackFolder() test bug

Tests

CI should pass

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

n/a

@gitguardian
Copy link

gitguardian bot commented Nov 4, 2022

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
3939057 Generic High Entropy Secret 8621dda service-commands/src/utils/constants.js View secret
4714545 Generic High Entropy Secret 8621dda service-commands/src/utils/constants.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@SidSethi SidSethi merged commit b0939d4 into main Nov 4, 2022
@SidSethi SidSethi deleted the ss-fix-test-creator-ci branch November 4, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants