Change frequent sync logs from info to debug #4288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanjunath
approved these changes
Nov 4, 2022
SidSethi
approved these changes
Nov 4, 2022
|
i wanna cherry pick this onto SP release |
|
sorry i merged - i'm in the middle of release stuff so just gonna do the cherrypick now |
|
no problem - I was just waiting for tests to pass and they did 👍 |
SidSethi
pushed a commit
that referenced
this pull request
Nov 4, 2022
SidSethi
pushed a commit
that referenced
this pull request
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes some sync logs from info to debug to avoid log pollution. These logs get printed for every 10 files processed, and a single sync can process thousands of files.
Tests
CI passing is sufficient.
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?
We shouldn't see logs for "processing files {X} to {Y}" outside of local dev.