Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CON-488 Fix CN GET /config_check route #4309

Merged
merged 3 commits into from
Nov 7, 2022
Merged

CON-488 Fix CN GET /config_check route #4309

merged 3 commits into from
Nov 7, 2022

Conversation

SidSethi
Copy link
Contributor

@SidSethi SidSethi commented Nov 7, 2022

Description

  1. Route is broken bc missing leading /
  2. Convert route response from JSON string to JSON object
  3. Change route response to JSON object
  4. Add integration test for route response

Tests

new test

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

n/a

@SidSethi SidSethi changed the title Fix CN GET /config_check route CON-488 Fix CN GET /config_check route Nov 7, 2022
dmanjunath
dmanjunath approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@dmanjunath dmanjunath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding another test

@SidSethi SidSethi merged commit b6e2702 into main Nov 7, 2022
@SidSethi SidSethi deleted the ss-fix-config-check branch November 7, 2022 22:53
dmanjunath pushed a commit that referenced this pull request Nov 14, 2022
@SidSethi @dmanjunath
CON-488 Fix CN GET /config_check route (#4309)
c52b5dc
sabrina-kiam pushed a commit that referenced this pull request Nov 16, 2022
@SidSethi
CON-488 Fix CN GET /config_check route (#4309)
92af414
@AudiusProject AudiusProject deleted a comment from linear bot Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanjunath dmanjunath dmanjunath approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SidSethi @dmanjunath