Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INF-302 Expose auto upgrading flag #4336

Merged
merged 5 commits into from
Nov 21, 2022
Merged

INF-302 Expose auto upgrading flag #4336

merged 5 commits into from
Nov 21, 2022

Conversation

endline
Copy link
Contributor

@endline endline commented Nov 11, 2022

Description

To allow introspection on whether host is running the auto upgrade cron as offered in audius-cli.
Was necessary to consume this from an env var as a container by design has no knowledge of host.

Additionally, the ask requested a flag to show whether using managed DB or not.
With the scope limited to that of simply checking for localhost. I'll add that this would give a false negative for something like a kube environment, whereby service names would be other than localhost.

RELATED PRs
AudiusProject/audius-docker-compose#144
https://github.com/AudiusProject/healthz/pull/1

Tests

# examine health check for new fields
# you can modify the auto upgrade enabled value in docker-compose.yml if desired
# which would be set by audius-cli in a deployed context

$ curl -s http://audius-protocol-creator-node-1:4000/health_check | jq [.data.autoUpgradeEnabled,.data.databaseIsLocalhost]
[
  false,
  true
]

$ curl -s http://audius-protocol-discovery-provider-1:5000/health_check | jq [.data.auto_upgrade_enabled,.data.database_is_localhost]
[
  false,
  true
]

docker-compose.yml Outdated Show resolved Hide resolved
endline added 3 commits November 21, 2022 16:47
@endline endline force-pushed the inf-302 branch 2 times, most recently from 8025d68 to c3ec103 Compare November 21, 2022 17:45
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 21, 2022
@SidSethi
Copy link
Contributor

merge conflict tho

@endline endline merged commit bda4782 into main Nov 21, 2022
@endline endline deleted the inf-302 branch November 21, 2022 19:42
@AudiusProject AudiusProject deleted a comment from linear bot Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants