Clean up nginx rules for content caching #4343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SidSethi
approved these changes
Nov 14, 2022
dmanjunath
added a commit
that referenced
this pull request
Nov 14, 2022
sabrina-kiam
pushed a commit
that referenced
this pull request
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains 2 changes
x-cache-status: STALEbut if the content was subsequently made available it wouldn't serve until it invalidated the stale content and it took a while to do that. I'm sure there's a better fix for this but seems better to disable since this is an simple optimistic cache.Tests
Tested locally by disabling this option and verifying that we don't see status
STALEanymore. Also content that was made available is returned immediately.Monitoring - How will this change be monitored? Are there sufficient logs / alerts?
No easy way to monitor this unfortunately. But can test very thoroughly because content should be served without issue through gateways.