[CON-517] Add a route to translate trackBlockchainId to copy320 CID #4377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaylor89
changed the title
SidSethi
suggested changes
Nov 18, 2022
| } | ||
|
|
||
| // make query | ||
| const queryResults = await models.File.findAll({ |
There was a problem hiding this comment.
have you benchmarked this query on prod DB? should make sure it uses an index / is performant
(can confirm this with explain analyze <query>
There was a problem hiding this comment.
I haven't yet. I'll check
There was a problem hiding this comment.
It seems it does use an index
There was a problem hiding this comment.
sweet - i wanna see what this looks like against prod DB with ~50k trackIDs
SidSethi
reviewed
Nov 18, 2022
SidSethi
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new route
/batch_id_to_cidthat translates a batch of trackBlockchainIds to copy320 CIDs.The return schema looks like
Tests
Tested locally by creating a user, uploading a track, and running curl to fetch the copy320.
And he's a test on the node cli to remove any suspicion that the functional code used to create the actually does work.
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?