Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C-1547] Add favoriteAlbums and favoriteTracks routes #4397

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

amendelsohn
Copy link
Contributor

Description

We need an endpoint to get all the favorited albums and one for playlists to support offline mode work. The client will need the full list of the user's favorites. We can handle the pagination on client side.

Haven't worked in this repo before, so please lmk if I'm missing steps.

Tests

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

@amendelsohn amendelsohn requested a review from a team November 23, 2022 21:30
@amendelsohn amendelsohn requested review from michellebrier and removed request for a team November 23, 2022 21:30
@amendelsohn amendelsohn requested review from a team, isaacsolo and jowlee and removed request for michellebrier November 23, 2022 21:30
Copy link
Member

@raymondjacobson raymondjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we usually do snake_case for routes, but preferably i’d say
/id/favorites/albums
/id/favorites/playlists
and make
/id/favorites and /id/favorites/tracks do the same

@amendelsohn
Copy link
Contributor Author

we usually do snake_case for routes, but preferably i’d say /id/favorites/albums /id/favorites/playlists and make /id/favorites and /id/favorites/tracks do the same

it looks like /id/favorites/tracks is already taken by the tracks full endpoint

@amendelsohn amendelsohn merged commit 74ad79f into main Nov 23, 2022
@amendelsohn amendelsohn deleted the amendel-get-favorite-collections branch November 23, 2022 22:25
@amendelsohn
Copy link
Contributor Author

Is there a version I should be bumping or do we do that in ci?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants