Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade CN ioredis and redis to v6.2.7 #4415

Merged
merged 3 commits into from
Dec 2, 2022
Merged

Upgrade CN ioredis and redis to v6.2.7 #4415

merged 3 commits into from
Dec 2, 2022

Conversation

theoilie
Copy link
Contributor

@theoilie theoilie commented Dec 1, 2022

Description

  • Upgrades redis from v5.0.2 to v6.2.7 (see changelog)
  • Upgrades ioredis from 4.27.5 to 5.2.4 (see changelog)
  • Changes tracing instrumentation from node-redis to ioredis since we don't use node-redis

Tests

  • Went through the changelogs linked in the description and spot checked any breaking changes to features we use
  • Made sure the stack comes up (this required very minor changes to other dependency versions like openresty)

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

Monitor logs for uncaught errors or any strange behavior. Search "redis" just in case.

@theoilie theoilie added the content-node Content Node (previously known as Creator Node) label Dec 1, 2022
jonaylor89
jonaylor89 approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@jonaylor89 jonaylor89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - looking forward to doing a full npm audit

SidSethi
SidSethi approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@SidSethi SidSethi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow - no code changes required at all?

creator-node/compose/docker-compose.yml Show resolved Hide resolved
@theoilie theoilie marked this pull request as ready for review December 2, 2022 02:57
@theoilie theoilie merged commit 1b996ea into main Dec 2, 2022
@theoilie theoilie deleted the theo-cn-upgrade-redis6 branch December 2, 2022 03:02
theoilie added a commit that referenced this pull request Dec 2, 2022
@theoilie
Upgrade CN ioredis and redis to v6.2.7 (#4415)
c17abea
@theoilie theoilie mentioned this pull request Dec 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SidSethi SidSethi SidSethi approved these changes

@jonaylor89 jonaylor89 jonaylor89 approved these changes

Assignees
No one assigned
Labels
content-node Content Node (previously known as Creator Node) size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@theoilie @SidSethi @jonaylor89