Fix CN mkdir called on grandparent instead of parent #4418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SidSethi
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
mkdirbeing called on the grandparent of a CID instead of the parent when it's nested. This is something I noticed for some legacy CIDs after turning debug logs on for prod CN5. It didn't corrupt any data and only caused some legacy CIDs to fail to be migrated until this is merged.Tests
Relying on CI instead of manual tests and will use debug logs to confirm the path is still correct. It still uses the same path logic that I already double-checked, so the risk for data loss is minimal.
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?
Look for errors with "Failed to copy some legacy files" and "ENOENT"