Update storagePaths for failed blacklisted CIDs #4423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes storagePath migrations ignore errors and still update the storagePath db column when a skipped legacy path fails to copy or a skipped custom path fails to fetch from network.
Tests
I did a sanity check and will do more thorough debugging on prod CN5. No data should be lost, and this will only impact skipped tracks - same logic otherwise.
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?
I'll monitor prod CN5 with debugging enabled to spot check any failed tracks and make sure they're not failing due to being unable to copy over from a skipped track. The logs to search for this are "Failed to copy legacy" and "Error fixing fileRecord"