Comms: round timestamps to microseconds on read #4826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stereosteve
approved these changes
Mar 8, 2023
michellebrier
force-pushed
the
mbrier/plat-706/round-timestamps
branch
from
d1e04f7
to
25c9c80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Postgres timestamps' max precision is microseconds but we format to nanoseconds in comms. Round on read (when not reading from postgres) to avoid issues. Writes and subsequent reads of timestamps from postgres are fine since postgres automatically rounds on write.
Tests will be fixed by 8a2762a
Tests
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?