PLAT-945: browser push feature flag #5191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacsolo
reviewed
May 2, 2023
| @@ -123,8 +133,11 @@ export class AppNotificationsProcessor { | |||
| ) | |||
| if (isEnabled) { | |||
| const isLiveEmailEnabled = this.getIsLiveEmailEnabled() | |||
| const isBrowserPushEnabled = this.getIsBrowserPushEnabled() | |||
| logger.info(`live email ${isLiveEmailEnabled ? "is" : "is not"} enabled`) | |||
There was a problem hiding this comment.
are these logs intentional for every notification? maybe move the gets outside too.
isaacsolo
approved these changes
May 2, 2023
sabrina-kiam
approved these changes
May 3, 2023
# Conflicts: # discovery-provider/plugins/notifications/src/processNotifications/mappers/create.ts # discovery-provider/plugins/notifications/src/processNotifications/mappers/repost.ts # discovery-provider/plugins/notifications/src/processNotifications/mappers/supportingRankUp.ts # discovery-provider/plugins/notifications/src/processNotifications/mappers/tastemaker.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds feature flag to control browser push through optimizely
Tests
testing on stage
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?