Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browser push when user doesn't have browsers #5192

Merged
merged 1 commit into from May 1, 2023

Conversation

isaacsolo
Copy link
Contributor

Description

This would throw an error when user doesn't have browsers

{"level":50,"time":"2023-05-01T19:02:13.095Z","name":"notifications","msg":"Error in sending Push API browser notifications TypeError: Cannot read property 'browser' of undefined"}

Tests

Tested in testing environment.

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

@isaacsolo isaacsolo merged commit 7e3e5ad into main May 1, 2023
3 of 17 checks passed
@isaacsolo isaacsolo deleted the is-fix-browser-notif branch May 1, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants