PLAT-955: default to local RPC and fallback to gateway #5239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondjacobson
approved these changes
May 16, 2023
| web3endpoint = LOCAL_RPC | ||
| logger.info("web3_provider.py | using local RPC") | ||
| else: | ||
| # if local rpc isn't healthy fall back to gateway |
There was a problem hiding this comment.
could be
try:
if 200:
# LOCAL_RPC
else:
raise Exception('local rpc unhealthy')
except Exception as e:
logger.warn(e)
web3endpoint = os...
alecsavvy
added a commit
that referenced
this pull request
May 17, 2023
This reverts commit ebdebcb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since ACDC has been functioning correctly for awhile discprov should be using its local node to index. This will reduce network latency and traffic to cloudflare will only be external RPC clients like web and mobile. There is a fallback if the node is unhealthy to use the RPC gateway should one node not report healthy.
Tests
Will run on a node on stage once build is complete.
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?
Logs showing which web3 provider was chosen will appear on startup. This will tell us if discprov thinks its local node is unhealthy and if it fell back to the gateway.