Increase csv field size limit in metadata backfill #5274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michellebrier
requested review from
a team and
isaacsolo
and removed request for
a team
michellebrier
requested review from
raymondjacobson
and removed request for
isaacsolo
|
maybe we should do like 500 as a safe buffer |
raymondjacobson
approved these changes
May 23, 2023
shouldnt be necessary, ran entire prod backfill successfully and ik the max field size in the tsv is 360KB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are 2 rows with metadata that is larger than python csv's default max field size of 128KB. Increase to 370KB
Tests
Ran prod backfill locally; succeeded
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?