Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C03] Updating or removing a service type causes critical accounting errors #555

Merged
merged 5 commits into from
Jun 25, 2020
Merged

[C03] Updating or removing a service type causes critical accounting errors #555

merged 5 commits into from
Jun 25, 2020

Commits on Jun 23, 2020

  1. Minor test cleanup

    @SidSethi
    SidSethi committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    a1aa29f View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2020

  1. Remove ServiceTypeManager.updateServiceType to remove delegation acco… 

    …unting vulnerability
    @SidSethi
    SidSethi committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    63338ee View commit details
    Browse the repository at this point in the history

  2. Fix ServiceTypeManager.removeServiceType() logic + add tests to confi… 

    …rm +& replace serviceTypeStakeInfo with serviceTypeInfo + update migrations, contracts, and tests
    @SidSethi
    SidSethi committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    c715819 View commit details
    Browse the repository at this point in the history

  3. Fix test race condition

    @SidSethi
    SidSethi committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    3b7de43 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. Ensure serviceType cannot be re-added + Validate stake bounds on serv… 

    …iceType creation. Add tests to confirm SP cannot register against invalid type & delegation is still possible after serviceType removal.
    @SidSethi
    SidSethi committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    80ff068 View commit details
    Browse the repository at this point in the history