Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[L04] Lack of indexed parameters in events #614

Merged
merged 7 commits into from
Jul 3, 2020
Merged

[L04] Lack of indexed parameters in events #614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
68207c4
SP factory indexed events
hareeshnagaraj Jul 3, 2020
2b3105c
Merge branch 'mainnet-audit-feedback' into hn_indexed_parameters_L04
hareeshnagaraj Jul 3, 2020
adc893e
Indexed parameter consolidation
hareeshnagaraj Jul 3, 2020
cdb1f49
Merge branch 'hn_indexed_parameters_L04' of github.com:AudiusProject/…
hareeshnagaraj Jul 3, 2020
644eff2
Merge branch 'mainnet-audit-feedback' into hn_indexed_parameters_L04
hareeshnagaraj Jul 3, 2020
9013a30
Test fix
hareeshnagaraj Jul 3, 2020
600d4f6
Merge branch 'hn_indexed_parameters_L04' of github.com:AudiusProject/…
hareeshnagaraj Jul 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions eth-contracts/contracts/ServiceProviderFactory.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,39 +83,39 @@ contract ServiceProviderFactory is InitializableV2 {
mapping(address => DecreaseStakeRequest) private decreaseStakeRequests;

event RegisteredServiceProvider(
uint256 _spID,
bytes32 _serviceType,
address _owner,
uint256 indexed _spID,
bytes32 indexed _serviceType,
address indexed _owner,
string _endpoint,
uint256 _stakeAmount
);

event DeregisteredServiceProvider(
uint256 _spID,
bytes32 _serviceType,
address _owner,
uint256 indexed _spID,
bytes32 indexed _serviceType,
address indexed _owner,
string _endpoint,
uint256 _unstakeAmount
);

event UpdatedStakeAmount(
address _owner,
uint256 _stakeAmount
address indexed _owner,
uint256 indexed _stakeAmount
);

event EndpointUpdated(
bytes32 _serviceType,
address _owner,
string indexed _oldEndpoint,
string indexed _newEndpoint,
uint256 _spID
bytes32 indexed _serviceType,
address indexed _owner,
string _oldEndpoint,
string _newEndpoint,
uint256 indexed _spID
);

event DelegateOwnerWalletUpdated(
address _owner,
address indexed _owner,
bytes32 indexed _serviceType,
uint256 indexed _spID,
address indexed _updatedWallet
address _updatedWallet
);

event ServiceProviderCutUpdated(
Expand Down
4 changes: 2 additions & 2 deletions eth-contracts/test/serviceProvider.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -944,8 +944,8 @@ contract('ServiceProvider test', async (accounts) => {
'EndpointUpdated',
{ _serviceType: web3.utils.padRight(testDiscProvType, 64),
_owner: stakerAccount,
_oldEndpoint: web3.utils.keccak256(testEndpoint),
_newEndpoint: web3.utils.keccak256(testEndpoint1),
_oldEndpoint: testEndpoint,
_newEndpoint: testEndpoint1,
_spID: spId
}
)
Expand Down