Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment updates #677

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Comment updates #677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions eth-contracts/contracts/DelegateManager.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,24 +35,24 @@ contract DelegateManager is InitializableV2 {
address private claimsManagerAddress;

/**
* Number of blocks an undelegate operation has to wait
* Period in blocks an undelegate operation is delayed.
* The undelegate operation speed bump is to prevent a delegator from
* attempting to remove their delegation in anticipation of a slash.
* @notice must be >= Governance.votingPeriod
* @notice Must be greater than governance votingPeriod + executionDelay
*/
uint256 private undelegateLockupDuration;

// Maximum number of delegators a single account can handle
/// @notice Maximum number of delegators a single account can handle
uint256 private maxDelegators;

// Minimum amount of delegation allowed
/// @notice Minimum amount of delegation allowed
uint256 private minDelegationAmount;

/**
* Lockup duration for a remove delegator request.
* The remove delegator speed bump is to prevent a service provider from maliciously
* removing a delegator prior to the evaluation of a proposal.
* @notice must be >= Governance.votingPeriod
* @notice Must be greater than governance votingPeriod + executionDelay
*/
uint256 private removeDelegatorLockupDuration;

Expand Down
8 changes: 8 additions & 0 deletions eth-contracts/contracts/ServiceProviderFactory.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,15 @@ contract ServiceProviderFactory is InitializableV2 {
address private governanceAddress;
address private serviceTypeManagerAddress;
address private claimsManagerAddress;

/// @notice Period in blocks that a decrease stake operation is delayed.
/// Must be greater than governance votingPeriod + executionDelay in order to
/// prevent pre-emptive withdrawal in anticipation of a slash proposal
uint256 private decreaseStakeLockupDuration;

/// @notice Period in blocks that an update deployer cut operation is delayed.
/// Must be greater than funding round block diff in order
/// to prevent manipulation around a funding round
uint256 private deployerCutLockupDuration;

/// @dev - Stores following entities
Expand Down