segmenting tests #700
segmenting tests #700
Conversation
There was a problem hiding this comment.
This is good work @vicky-g. Few small comments but overall looks good
| .attach('file', file, { filename: 'fname.mp3' }) | ||
| .set('Content-Type', 'multipart/form-data') | ||
| .set('X-Session-ID', session) | ||
| .expect(500) |
There was a problem hiding this comment.
is there a way to verify the error messages?
There was a problem hiding this comment.
for some reason, the response body does not actually contain the error message, but contains an empty response in response.body.error:
error: {}
and instead has an this message in response.error:
'cannot POST /track_content (500)'
did some digging into why, and after testing a few options, could not conclude as to why the actual error message was not propogating.
fwiw, I traced though the exact lines to make sure that the /track_content error was exactly the intended errors I created through sinon
vicky-g
force-pushed
the
vg-segmenting-tests-2
branch
from
0b2e890
to
058d185
Compare
vicky-g
force-pushed
the
vg-segmenting-tests-2
branch
from
5f49f17
to
303e29e
Compare
| @@ -40,3 +40,7 @@ mkdir -p $storagePath | |||
| ./node_modules/mocha/bin/mocha --timeout 30000 --exit | |||
|
|
|||
| rm -r $storagePath | |||
|
|
|||
There was a problem hiding this comment.
do we need to add the delegate wallet and private key here for local testing?
There was a problem hiding this comment.
yes, i've been manually adding these values to the default-config.json for local testing, but adding here would be much more effective. will add keys here
There was a problem hiding this comment.
perfect! i was actually just about to comment on the resize image test and ask you to move your delegate key pair into the run-tests.sh file. if you remove it from default-config.json and add it to run-tests.sh and make sure it's consistent in both pr's i think we can merge these!
No description provided.