-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obfuscate IDs in Creator Node stream route #717
Conversation
b57884d
to
7f793f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I also want to get @SidSethi or @hareeshnagaraj's eyes on this cause it involves the gateway api route
Don't know if you saw already, but looks like there's some lint errors @piazzatron |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good from my view. per offline discussion, lets just flesh out the PR description with your local QA testing checklist + some code comments clarifying the handleResponse / stream weirdness
also unit test per today's process change 🙂
577b1f6
to
7091c64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding the docs + test 🙂
Testing
Additional Notes