Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obfuscate IDs in Creator Node stream route #717

Merged
merged 6 commits into from
Aug 6, 2020

Conversation

piazzatron
Copy link
Contributor

@piazzatron piazzatron commented Jul 31, 2020

Testing

Additional Notes

  • This also fixed a previously unknown bug where we didn't wrap this endpoint handleResponse, causes it to stall forever rather than returning non-200 responses.

Copy link
Contributor

@dmanjunath dmanjunath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I also want to get @SidSethi or @hareeshnagaraj's eyes on this cause it involves the gateway api route

creator-node/src/routes/tracks.js Outdated Show resolved Hide resolved
@dmanjunath dmanjunath requested a review from SidSethi July 31, 2020 22:02
@dmanjunath
Copy link
Contributor

Don't know if you saw already, but looks like there's some lint errors @piazzatron

Copy link
Contributor

@SidSethi SidSethi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from my view. per offline discussion, lets just flesh out the PR description with your local QA testing checklist + some code comments clarifying the handleResponse / stream weirdness

also unit test per today's process change 🙂

Copy link
Contributor

@SidSethi SidSethi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding the docs + test 🙂

@piazzatron piazzatron merged commit 7fb99ad into master Aug 6, 2020
@piazzatron piazzatron deleted the piazz-hash-ids-creator-node branch August 6, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants