Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable @audius/libs npm link for local dev #720

Merged
merged 5 commits into from
Aug 1, 2020
Merged

Enable @audius/libs npm link for local dev #720

merged 5 commits into from
Aug 1, 2020

Conversation

hareeshnagaraj
Copy link
Contributor

@hareeshnagaraj hareeshnagaraj commented Aug 1, 2020 •
edited

  • Explicitly mount libs and link for local development in identity and creator nodes
  • Toggled by setting link_libs=true in identity-service/scripts/dev-server.sh and creator-node/scripts/dev-server.sh

Tested by:

  • Modifying local libs with test output on init
  • Bringing up the entire audius system with 2 cnodes
  • Inspect cn1, cn2, identity logs to confirm test output and libs link
  • Modify host libs with additional changes
  • cat modified file from each containers /app/node_modules/@audius/libs/ to confirm changes are picked up

@hareeshnagaraj hareeshnagaraj changed the title Always link @audius/libs Enable @audius/libs npm link for local dev Aug 1, 2020
dmanjunath
dmanjunath approved these changes Aug 1, 2020
View reviewed changes
Copy link
Contributor

@dmanjunath dmanjunath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea. Tested all of this locally and it seems to work great

@hareeshnagaraj hareeshnagaraj merged commit ea36e42 into master Aug 1, 2020
@hareeshnagaraj hareeshnagaraj deleted the hn_libs_link branch August 1, 2020 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanjunath dmanjunath dmanjunath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hareeshnagaraj @dmanjunath