[PAY-2681] Artist dashboard album support #8136

dharit-tan · 2024-04-17T01:59:03Z

Description

Adds album support for artist dashboard. Gated on premium albums feature flag.

The gist is that we already fetch the signed-in user's collections on app load, so we don't need to worry about fetching them here. The track fetching is handled the same way as in the current world (paginated API calls). Ideally the track vs album data fetching/caching would be handled the same way, but alas.. I did think about adding an endpoint to fetch all albums belonging to a given user id, but that was more work and it would have added an extra request given how audius-query interfaces with our cache currently, so decided to go the easy route.

cc @dylanjeffers for TextInput change.

Some todos:

Overflow menu doesn't work for albums - need to make a new CollectionsTable ([PAY-2711] CollectionsTable component #8147)
Left margin is too large for small TextInput variant with icon.
Need to add favorites column: [PAY-2701] Add favorites (saves) column to TracksTable #8140

How Has This Been Tested?

Screen.Recording.2024-04-16.at.9.55.44.PM.mov

changeset-bot · 2024-04-17T01:59:06Z

⚠️ No Changeset found

Latest commit: a994f24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

audius-infra · 2024-04-17T02:11:30Z

Preview this change https://demo.audius.co/rt-artist-dashboard

audius-infra · 2024-04-17T19:02:54Z

Preview this change https://demo.audius.co/rt-artist-dashboard

amendelsohn

Nice job! Surprising amount of state management involved. Well done keeping it straight!

I'm curious if it's possible to split up the component to make this easier to read and maintain. See my last comment for suggestions. Also happy to chat or pair on this!

packages/common/src/store/account/selectors.ts

packages/web/src/pages/dashboard-page/components/ArtistContentSection.tsx

schottra

Generally agree with Andrew here: It would be nice to separate this out and make use of sub components for organization and separation of concerns. But otherwise looks good 👍

packages/web/src/pages/dashboard-page/components/ArtistContentSection.tsx

audius-infra · 2024-04-19T20:36:26Z

Preview this change https://demo.audius.co/rt-artist-dashboard

amendelsohn

Great refactor! So much nicer now that the filter and conditional display logic are not jammed into the same component.

A few ideas and comments, but don't want to put you through too many rounds of refactoring. It's good as is if you just want to ship it.

packages/web/src/pages/dashboard-page/components/AlbumsTab.tsx

packages/web/src/pages/dashboard-page/components/ArtistContentSection.tsx

audius-infra · 2024-04-19T22:41:51Z

Preview this change https://demo.audius.co/rt-artist-dashboard

amendelsohn

Love how clean the components are now! Great job!

packages/web/src/pages/dashboard-page/components/constants.ts

packages/web/src/pages/dashboard-page/components/hooks.ts

schottra

Much cleaner with the refactor. Thanks for indulging us!
LGTM

packages/web/src/pages/dashboard-page/components/AlbumsTab.tsx

packages/web/src/pages/dashboard-page/components/ArtistContentSection.tsx

packages/web/src/pages/dashboard-page/components/TracksTab.tsx

packages/web/src/pages/dashboard-page/components/hooks.ts

audius-infra · 2024-04-22T19:08:49Z

Preview this change https://demo.audius.co/rt-artist-dashboard

audius-infra · 2024-04-22T20:35:53Z

Preview this change https://demo.audius.co/rt-artist-dashboard

[6eab8d7] [PROTO-1783] Finish entrypoint UI (#8246) Raymond Jacobson [02787da] Fix UserNameAndBadges line-height (#8248) Reed [efc2eed] Remove locked pill, gray row in TracksTable (#8241) Reed [ca479c2] [PAY-2704] Show content type icon in last cell of row in TracksTable (#8243) Reed [55dbd22] [ONC-81] Fix giant track tile visual bug (#8240) JD Francis [59c2f32] [PAY-2616] Fix Add Funds modal closing and balance (#8237) Saliou Diallo [ec47b83] [INF-691] Add back CI step to verify generated sdk types (#8199) Sebastian Klingler [be974f0] Disable hidden album upload feature (#8239) JD Francis [a065720] [PROTO-1787] Add full screen oauth variant (#8233) Raymond Jacobson [eeb575f] Bump mobile app versions (#8236) nicoback2 [acacb93] [PAY-2746] Add authorized apps settings (#8214) Raymond Jacobson [65179fd] [INF-670] Add check for wildcard deps in public packages (#8230) Sebastian Klingler [651f18d] [PAY-2616] Fix CTA for reward panel (#8232) Saliou Diallo [f340e0f] Mobile lint import reorders (#8229) Reed [c02c55c] TracksTable lint fix (#8228) Reed [d49c5ec] Rename audius-mobile-client -> @audius/mobile (#8226) Sebastian Klingler [be9f0b2] [PAY-2739] show purchase button on tracks table mobile web (#8208) Andrew Mendelsohn [a646fa6] [INF-459] Rename audius-client -> @audius/web (#8204) Sebastian Klingler [016a94b] [PAY-2725] Add purchase button to mobile web albums (#8206) Andrew Mendelsohn [2ab3792] [PAY-2727] Add images to oauth popup (#8216) Raymond Jacobson [fc5127c] [PAY-2745] Hide play count for premium tracks (#8215) Reed [342d610] [PAY-2749] Use ownerWallet instead of delegateOwnerWallet for uniquely owned endpoints in SDK (#8217) Marcus Pasell [3bba9ab] [PAY-2731] Web FilterButton transparent when disabled (#8213) Reed [3cfc215] [PAY-2550] Add images to apps (#8196) Raymond Jacobson [4f0c6e1] [PAY-2737] Fix mobile collection tile formatting (#8205) Andrew Mendelsohn [ffba9e9] [PAY-2719] Hidden album upload (#8191) JD Francis [7793044] Fix web-test pt 2 (#8201) Sebastian Klingler [1a1e687] [PAY-2741] Artist dashboard album stat (#8200) Reed [18c907a] [PAY-2712] Mobile collection header (#8173) JD Francis [c2d0289] [PAY-2730] Artist Dashboard empty tab states (#8192) Reed [b65db45] Fix signature in SDK rewards (#8195) Marcus Pasell [d127b48] [ONC-79] Fix reward formatting bug (#8194) Saliou Diallo [79c4acc] [C-3921] Stop sending signature headers as params (#7774) Raymond Jacobson [f6281bd] Undo a dev override that got checked in (#8198) Randy Schott [6832772] Fix web TextInput small variant icon left padding (#8176) Reed [1693e01] [PAY-2711] CollectionsTable component (#8147) Reed [8c3d050] [PAY-2701] Add favorites (saves) column to TracksTable (#8140) Reed [d71db62] [INF-535] Fix web-test (#8185) Sebastian Klingler [4e636ad] [PAY-2720] Fixes issues with checking for recovery on load (#8186) Randy Schott [5d5e076] [PAY-2399] Update header and cell contents for withdrawals table (#8184) Randy Schott [37258ec] [PAY-2681] Artist dashboard album support (#8136) Reed [8feb22b] [PAY-2656] Filter out premium albums from feed if FF off (#8181) Reed [e190a34] Fix web-init (#8183) JD Francis [64937c6] [C-4282] Add cooldown summary table to individual reward modals on web (#8177) Saliou Diallo [ac4d7e5] [PAY-2702] Desktop collection header desktop rework (#8156) JD Francis [45969ac] Use https for talking to solana relay on prod (#8174) Marcus Pasell [164b322] [ONC-76] Exclude backgroundColor from forwardedProps for Box (#8168) Randy Schott [29ec233] [PAY-2615] Add support for common LUT in versioned transactions (#8157) Randy Schott [60f3bd1] Upgrade sentry to fix iOS build errors (#8170) Randy Schott

dharit-tan added 2 commits April 16, 2024 21:51

[PAY-2681] Artist dashboard album support

2f4865d

lint

ce2a5e3

dharit-tan requested review from schottra, amendelsohn and dylanjeffers April 17, 2024 01:59

dharit-tan assigned rickyrombo Apr 17, 2024

pull-request-size bot added the size/L label Apr 17, 2024

filterbutton popup menu positioning

1405861

This was referenced Apr 18, 2024

[PAY-2711] CollectionsTable component #8147

Merged

[PAY-2701] Add favorites (saves) column to TracksTable #8140

Merged

amendelsohn approved these changes Apr 18, 2024

View reviewed changes

schottra reviewed Apr 18, 2024

View reviewed changes

refactor

448dd0a

pull-request-size bot added size/XL and removed size/L labels Apr 19, 2024

dharit-tan requested review from amendelsohn and schottra April 19, 2024 20:09

cleanup

2a354d6

amendelsohn reviewed Apr 19, 2024

View reviewed changes

dharit-tan added 2 commits April 19, 2024 17:36

rename, constant

26ea1cd

hooks refactor

ea45dbb

amendelsohn approved these changes Apr 22, 2024

View reviewed changes

packages/web/src/pages/dashboard-page/components/constants.ts Outdated Show resolved Hide resolved

packages/web/src/pages/dashboard-page/components/hooks.ts Outdated Show resolved Hide resolved

rename constants

3eb0c34

schottra approved these changes Apr 22, 2024

View reviewed changes

randy PR comments

a994f24

dharit-tan enabled auto-merge (squash) April 22, 2024 20:33

dharit-tan merged commit 37258ec into main Apr 22, 2024
24 of 27 checks passed

dharit-tan deleted the rt-artist-dashboard branch April 22, 2024 21:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PAY-2681] Artist dashboard album support #8136

[PAY-2681] Artist dashboard album support #8136

dharit-tan commented Apr 17, 2024 •

edited

changeset-bot bot commented Apr 17, 2024 •

edited

audius-infra commented Apr 17, 2024

audius-infra commented Apr 17, 2024

amendelsohn left a comment •

edited

schottra left a comment

audius-infra commented Apr 19, 2024

amendelsohn left a comment

audius-infra commented Apr 19, 2024

amendelsohn left a comment

schottra left a comment

audius-infra commented Apr 22, 2024

audius-infra commented Apr 22, 2024

[PAY-2681] Artist dashboard album support #8136

[PAY-2681] Artist dashboard album support #8136

Conversation

dharit-tan commented Apr 17, 2024 • edited

Description

How Has This Been Tested?

changeset-bot bot commented Apr 17, 2024 • edited

⚠️ No Changeset found

audius-infra commented Apr 17, 2024

audius-infra commented Apr 17, 2024

amendelsohn left a comment • edited

Choose a reason for hiding this comment

schottra left a comment

Choose a reason for hiding this comment

audius-infra commented Apr 19, 2024

amendelsohn left a comment

Choose a reason for hiding this comment

audius-infra commented Apr 19, 2024

amendelsohn left a comment

Choose a reason for hiding this comment

schottra left a comment

Choose a reason for hiding this comment

audius-infra commented Apr 22, 2024

audius-infra commented Apr 22, 2024

dharit-tan commented Apr 17, 2024 •

edited

changeset-bot bot commented Apr 17, 2024 •

edited

amendelsohn left a comment •

edited